Disable terminal actions for now #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dosubot
bot
added
the
size:L
mrubens
approved these changes
Mar 5, 2025
Contributor
Collaborator
Author
This was referenced Mar 8, 2025
cte
pushed a commit
that referenced
this pull request
Mar 11, 2025
This commit partially addresses the issue of duplicate handler calls by removing an unnecessary instantiation of TerminalManager in registerTerminalActions.ts. Move the getTerminalContents method from TerminalManager to Terminal class as a static method and update all references to use the new location. Fixes: #1380 Signed-off-by: Eric Wheeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Reference: #1364
TerminalManagershould be a singleton, so let's disable terminal actions until we can appropriately share the terminal manager. We can also improve the way these actions work.Implementation
Screenshots
How to Test
Get in Touch
Important
Disables terminal actions by removing related commands and unregistering them, pending a singleton
TerminalManagerimplementation.package.json.registerTerminalActionsfromindex.tsandextension.ts.registerTerminalActions.tswhich contained terminal action registration logic.package.jsonundercommandsandmenus.activate()inextension.tsto exclude terminal actions registration.This description was created by
for 75dcc2f. It will automatically update as commits are pushed.